FDM solver for the de Rham complex #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pefarrell
requested changes
Mar 9, 2023
pefarrell
previously requested changes
Mar 16, 2023
|
Merge together with TSFC #287 |
pbrubeck
dismissed stale reviews from connorjward and pefarrell
Changes have been addressed
dham
requested changes
May 3, 2023
dham
previously approved these changes
May 10, 2023
dham
reviewed
May 10, 2023
pefarrell
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
FDMPCto discretize a sparse auxiliary operator for de Rham-conforming discretizations on quads and hexes using elements withvariant="fdm".The previous behaviour of
FDMPCtargeted an IPDG discretization of a Poisson-like problem (grad u, alpha grad v) + (u, beta v) on non H1-conforming elements. This is still accessible throughPoissonFDMPCand using elements withvariant="fdm_ipdg".